[Webkit-unassigned] [Bug 95057] [chromium] Allow impl-thread deletion of only some resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95057





--- Comment #4 from Christopher Cameron <ccameron at chromium.org>  2012-08-27 10:07:35 PST ---
(In reply to comment #3)
> (From update of attachment 160669 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160669&action=review
> 
> > Source/WebKit/chromium/ChangeLog:13
> > +        Remove the test releaseContentsTextureShouldTriggerCommit because it
> > +        is no longer valid -- a releaseContentsTexture will only trigger a
> > +        commit if some resources are deleted.
> 
> I do wonder about testing for this. What about testing these two things? Commit happens on delete, doesn't happen on no delete.

The commit logic has moved out of CCLayerTreeHostImpl and moved into CCProxy.  There does exist a test, CCLayerTreeHostTestEvictTextures, which checks the commits that come in and pairs them with evictions.

Now that you mention it though, I did not include the update in CCSingleThreadProxy (so I wonder how that passed).  I'll look into making a test that fails if the commit doesn't happen (or updating the CCLayerTreeHostTestEvictTextures test to fail appropriately when the commit doesn't happen).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.