[Webkit-unassigned] [Bug 94806] [GStreamer][Qt] WebAudio support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94806





--- Comment #8 from Philippe Normand <pnormand at igalia.com>  2012-08-27 06:29:59 PST ---
(In reply to comment #6)
> (From update of attachment 160686 [details])
> 
> > Source/WebCore/platform/audio/qt/AudioBusQt.cpp:30
> > +PassOwnPtr<AudioBus> AudioBus::loadPlatformResource(const char* name, float sampleRate)
> 
> I suggest to rewrite the entire function to be a lot simpler. There is no need to support AUDIO_RESOURCES_PATH, because there is no "uninstalled case". Qt resources are compiled into the library and are therefore always available at run-time. createBusFromAudioFile() however won't work, because it uses filesrc in gstreamer, which does not support Qt resources. Therefore I suggest to boil this down to
> something along the lines of this:
> 
> QString path = QStringLiteral(":/webkit/resources/audio/");
> path.append(QLatin1String(name));
> QResource resource(path);
> return createBusFromInMemoryAudioFile(resource.data(), resource.size(), /* mixToMono */false, sampleRate);
> 

Hum that sounds like a great idea yes but the Composite resource is not found in the binary I build, should I pass any specific option apart from the .qrc file update?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.