[Webkit-unassigned] [Bug 40300] Web Inspector: [JSC] implement script source editing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40300





--- Comment #82 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-08-27 05:11:32 PST ---
(In reply to comment #81)
> > > I believe this test case will fail, given your approach to code editing.
> > 
> > I did a test, my patch can pass this test. :)
> 
> I don't think you ran the test right. I don't see any code in this patch that would make it work.

Sorry, I did a test again with newest code, my patch doesn't pass this test, and V8 can pass it. :(

However, the reason is not that the embedded functions aren't be recompiled. In JSC, the expression  
var aa = function button1Click() {...};
is compiled as there is a function declaration with name "aa" (refer to JSC::AssignResolveNode::emitBytecode). And we need "execute" these bytecodes to make "aa" to become related with the new function body.

The book "JavaScript: The Definitive Guide" says, for that type of expression, like 
var aa = function button1Click() {...}; 
"aa" should work like a pointer to the function. 
I'm not expert of javascript syntax, maybe it's a defect of JSC implementation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.