[Webkit-unassigned] [Bug 94806] [GStreamer][Qt] WebAudio support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94806





--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2012-08-27 04:52:13 PST ---
(From update of attachment 160686)
View in context: https://bugs.webkit.org/attachment.cgi?id=160686&action=review

Looks good in general! A few small comments.

> Source/WebCore/platform/audio/HRTFElevation.cpp:63
> +#if PLATFORM(GTK) || PLATFORM(MAC) || PLATFORM(EFL) || PLATFORM(QT)

Should this be PLATFORM(MAC) || USE(WEBAUDIO_STUFF_WITH_STREAMER_OR_SOMETHING)?

>> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:30
>> +#endif
> 
> Deserves comment I think

I'm surprised this is still needed anyway. I thought Lauro removed all uses of "signals:" in WebKit and the Qt headers should be clean, i.e. use Q_SIGNALS. Are you sure this is still needed?

> Source/WebCore/platform/audio/qt/AudioBusQt.cpp:30
> +PassOwnPtr<AudioBus> AudioBus::loadPlatformResource(const char* name, float sampleRate)

I suggest to rewrite the entire function to be a lot simpler. There is no need to support AUDIO_RESOURCES_PATH, because there is no "uninstalled case". Qt resources are compiled into the library and are therefore always available at run-time. createBusFromAudioFile() however won't work, because it uses filesrc in gstreamer, which does not support Qt resources. Therefore I suggest to boil this down to
something along the lines of this:

QString path = QStringLiteral(":/webkit/resources/audio/");
path.append(QLatin1String(name));
QResource resource(path);
return createBusFromInMemoryAudioFile(resource.data(), resource.size(), /* mixToMono */false, sampleRate);

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:160
> +        clean_env['AUDIO_RESOURCES_PATH'] = self._filesystem.join(self._config.webkit_base_dir(),
> +                                                                  'Source', 'WebCore', 'platform', 'audio', 'resources')

I don't think that this is needed, given that qt resources are compiled into the webkit library.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.