[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #34 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-08-27 04:17:46 PST ---
(From update of attachment 160672)
View in context: https://bugs.webkit.org/attachment.cgi?id=160672&action=review

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:56
> +const int maxBuffer = 128;

Do you want it to be exported? if not should be static or inside a nameless namespace.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:59
> +inline String getToken(FILE* file)

ditto. Even though 'inline' may have similar qualities as 'static' this behavior is compiler(and even compiler setting)-specific.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:71
>> +inline void appendMemoryStats(WebMemoryStatistics& webKitMemoryStats, String key, size_t value)
> 
> const String& key

ditto.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:77
> +void sampleSystemMemoryInfo(WebMemoryStatistics& statics)

ditto.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:99
> +ApplicationMemoryStats sampleApplicationMalloc()

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.