[Webkit-unassigned] [Bug 94806] [GStreamer][Qt] WebAudio support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94806





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-08-27 03:39:42 PST ---
(From update of attachment 160686)
View in context: https://bugs.webkit.org/attachment.cgi?id=160686&action=review

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:30
> +#if PLATFORM(QT)
> +#undef signals
> +#endif

Deserves comment I think

> Source/WebCore/platform/audio/qt/AudioBusQt.cpp:38
> +        QString environmentPath = QString::fromUtf8(qgetenv("AUDIO_RESOURCES_PATH"));
> +        if (environmentPath.isEmpty()) {

Why not just use String?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.