[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72811


Joanmarie Diggs <jdiggs at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160549|0                           |1
        is obsolete|                            |
 Attachment #160549|review?                     |
               Flag|                            |
 Attachment #160678|                            |review?, commit-queue?
               Flag|                            |




--- Comment #34 from Joanmarie Diggs <jdiggs at igalia.com>  2012-08-27 02:21:28 PST ---
Created an attachment (id=160678)
 --> (https://bugs.webkit.org/attachment.cgi?id=160678&action=review)
proposed fix - part 2 (addressed feedback from review)

(In reply to comment #33)
> (From update of attachment 160549 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160549&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1956
> > +    if (node && node->hasTagName(spanTag))
> 
> we should have a comment here as to why all span tags need to be ignored

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.