[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #32 from JungJik Lee <jungjik.lee at samsung.com>  2012-08-27 02:12:11 PST ---
(From update of attachment 160467)
View in context: https://bugs.webkit.org/attachment.cgi?id=160467&action=review

>>> Source/WTF/wtf/Platform.h:1173
>>> +#endif
>> 
>> Why do you even need that??
>> 
>> None of the code is in common WebKit.
> 
> Why do you even need that??
> 
> None of the code is in common WebKit.

I moved it to PlatformEfl.cmake. thanks your comment.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:34
>> +#include <malloc.h>
> 
> This is *very* deprecated, and you don't seem to allocate memory with malloc(3) and friends at all.

Done, I removed it.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:64
>> +    memset(buffer, 0, maxBuffer);
> 
> Please include string.h for memset(3).

Done, I added string.h.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:65
>> +    fscanf(file, "%s", buffer);
> 
> And stdio.h for fscanf(3).

Done, I added stdio.h too.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:129
>> +    size_t totalBytesInUse = 0, totalBytesCommitted = 0;
> 
> One variable per line, please.

Done and thanks your comments.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:152
>> +    webKitMemoryStats.keys.append(String("Timestamp"));
> 
> As WebMemoryStatistics has standard pattern like below, consider create a function to reduce line numbers inside this function.
> 
> struct WebMemoryStatistics
> {
>     Vector<String> keys;
>     Vector<size_t> values;
> };

it's fixed by following your comment. thanks.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:748
>> +#endif
> 
> Why all this instead of using the existing infrastructure for enabling and starting the memory sampler?

could you let me know what the existing infrastructure is?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.