[Webkit-unassigned] [Bug 77969] WebKitTestRunner should support notifications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77969





--- Comment #14 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-08-27 01:42:26 PST ---
Attachment 160668 did not pass style-queue:

Tools/WebKitTestRunner/TestController.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/DumpRenderTree/mac/MockWebNotificationProvider.h:61:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h:53:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNotification.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNotification.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/WebKitTestRunner/WebNotificationProvider.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h:75:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageNotificationClient.h:50:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageNotificationClient.h:50:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:167:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:167:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:168:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:168:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:169:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:169:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:170:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:170:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:171:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:171:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:172:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:172:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:173:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:173:  The parameter name "notification" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:174:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:174:  TFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
he parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 25 in 89 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.