[Webkit-unassigned] [Bug 85494] [EFL] Wrong button height on CSS tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85494





--- Comment #4 from KyungTae Kim <ktf.kim at samsung.com>  2012-08-26 17:34:50 PST ---
What I mean was only the EFL port overrides the Border,WhiteSpace,Height style now. The overriding codes seems coming from GTK port's old codes that are no longer exists. 

I'll explain why the overriding code must be removed, line by line :

  if (style->appearance() == PushButtonPart) {  // Setting style only for <input type=button>, not <button>

    style->resetBorder();  // This code cause reset border style for button - 2px outset - to initial value. This code makes the size of <input type=button> different from the size of <button>, it makes 'fast/css/button-height.html' fail that check whether they are same.

    style->setWhiteSpace(PRE);  // This code is not needed because the white space for buttons already set to 'PRE'

    style->setHeight(Length(Auto)); // This code override the style for height, it makes 'fast/css/button-height.html' fail that set the button's height style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.