[Webkit-unassigned] [Bug 94926] Remove parent pointer from StyleSheetInternal and StyleRuleImport
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 26 14:17:33 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=94926
Andreas Kling <kling at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #160612|review? |review+
Flag| |
--- Comment #5 from Andreas Kling <kling at webkit.org> 2012-08-26 14:17:34 PST ---
(From update of attachment 160612)
View in context: https://bugs.webkit.org/attachment.cgi?id=160612&action=review
r=me
> Source/WebCore/css/StyleRuleImport.h:-59
> - // NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it
> - // to avoid adding a vptr to StyleRuleImport.
> - class ImportedStyleSheetClient : public CachedStyleSheetClient {
Glad to see this hack disappear!
> Source/WebCore/css/StyleSheetContents.cpp:340
> + m_didLoadErrorOccur = true;
Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list