[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #26 from Kangil Han <kangil.han at samsung.com>  2012-08-24 18:29:30 PST ---
(From update of attachment 160413)
View in context: https://bugs.webkit.org/attachment.cgi?id=160413&action=review

>>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:81
>>> +            } else if (foundKeyName) {
>> 
>> When program comes in? Seems 'foundKeyName' always 'false' before if condition.
> 
> Yes, if the token has not colon, it will be the value.

This looks 'if, else if' implementation.
Looks foundKeyName only being set 'true' inside 'if' loop.
How it would affect 'else if' loop in this function?

>>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:109
>>> +    return applicationStats;
>> 
>> Then this would be 'return 0'
> 
> this function returns structure type.

Yes, it is true. I overlooked it.

>>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:114
>>> +    String processName;
>> 
>> We would put this line inside if condition.
> 
> I don't understand the reason.

Search with 'String()' in webkit source code.
It's WebKit style. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.