[Webkit-unassigned] [Bug 94384] screenToWindow and windowToScreen are not implemented in Qt5 WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94384


Andras Becsi <abecsi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159211|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Andras Becsi <abecsi at webkit.org>  2012-08-24 10:39:29 PST ---
(From update of attachment 159211)
(In reply to comment #5)
> Do you have any suggestion on how to do it better? I'm especially confused on how the QWindow and QQuickItem coordinates match. Aren't scene coordinates just another name for window coordinates or are they different? In screenToWindow(), should I do m_webView->mapToScene(window->mapFromGlobal(point)) or am I completely lost?
>
I'm not sure I understand in what way you are trying to use these functions so I can not help you with that.

> For windowToScreen, the parameter is indeed displaced because of the URL bar and that's what I was trying to fix in the first place. My understanding was that the "window" here is actually the "webkit window", a QQuickWebView, not the actual QWindow, hence the need to map them to the scene.

AFAICT screenToWindow should do window->mapFromGlobal(point) and windowToScreen should return IntRect(window->mapToGlobal(rect.location()), rect.size()).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.