[Webkit-unassigned] [Bug 94384] screenToWindow and windowToScreen are not implemented in Qt5 WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94384





--- Comment #4 from Andras Becsi <abecsi at webkit.org>  2012-08-24 09:19:28 PST ---
(From update of attachment 159211)
View in context: https://bugs.webkit.org/attachment.cgi?id=159211&action=review

I think this patch is incorrect and might event break layout tests.

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:196
> +    QPointF itemPoint(point);

I find the name "itemPoint" a bit confusing for a point in absolute screen coords. Could be screenPoint maybe?

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:203
> +    return window->mapFromGlobal(screenPoint.toPoint());

This seems wrong to me since mapFromGlobal translates global screen coordinates to window coordinates and you previously mapped the incoming screen position to QQuickWebView item coordinates.

> Source/WebKit2/UIProcess/qt/QtPageClient.cpp:212
> +    QRectF itemRect(rect);
> +    QRectF screenRect = m_webView->mapRectToScene(itemRect);

The incoming rect should be in window coordinates and not in QQuickWebView item coordinates (the view itself might be displaced within the window because of the URL bar or other items) thus this conversion seem also wrong to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.