[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #18 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-24 02:58:00 PST ---
(From update of attachment 160361)
View in context: https://bugs.webkit.org/attachment.cgi?id=160361&action=review

I think this patch includes Bug 91274 functionality. So, it looks this patch is valuable for us. Any other opinions ?

Anyway, I think detail implementation should be reviewed further. I'm going to review it further.

> Source/JavaScriptCore/ChangeLog:3
> +        [EFL][CMAKE] Add WebMemorySampler option.

Add [EFL][WK2] prefix to bug title.

> Source/WTF/ChangeLog:3
> +        [EFL] Add WebMemorySampler option.

ditto.

> Source/WebKit2/ChangeLog:3
> +        [EFL] Add WebMemorySampler feature.

ditto.

> Source/JavaScriptCore/PlatformEfl.cmake:3
>      jit/ExecutableAllocator.cpp

Add a new line to distinguish different directories.

> Source/WebKit2/PlatformEfl.cmake:25
> +    Shared/WebMemorySampler.cpp

ditto.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:27
> +

Unneeded line.

> Source/cmake/OptionsEfl.cmake:82
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER ON)

You have to add this macro to Source/cmakeconfig.h.cmake as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.