[Webkit-unassigned] [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89666


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157992|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #23 from Simon Hausmann <hausmann at webkit.org>  2012-08-23 23:13:57 PST ---
(From update of attachment 157992)
View in context: https://bugs.webkit.org/attachment.cgi?id=157992&action=review

This patch is missing a ChangeLog, which I suppose would provide an explanation as to why these changes are submitted? :)

I'm particularly curious why the disk cache directory needs to be per DRT/WTR instance.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:-95
> -    ASSERT(!parameters.nsURLCachePath.isEmpty());

Technically this ASSERT should move somewhere else, shouldn't it?

> Tools/WebKitTestRunner/TestController.cpp:320
> +        WKContextSetDatabaseDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> +        WKContextSetLocalStorageDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> +        WKContextSetDiskCacheDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));

I think you need to store the strings created by WKStringCreate* in a RetainPtr to avoid them leaking.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.