[Webkit-unassigned] [Bug 94779] To reduce cost of converting type during modulo for integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94779





--- Comment #6 from hojong.han at samsung.com  2012-08-23 19:20:24 PST ---
(In reply to comment #5)
> I think he means both.  It appears that you have not tested this case.  I think that just running layout tests should be enough - we should have excellent coverage over corner cases of integer modulo.
> 
> That said, your code will pretty obviously cause badness (the speculationCheck() is invoked in the wrong place, and you're only checking for one of the corner cases, not all of them) so if layout tests do pass by some fluke, then you should add a new layout test or file a bug against Tools/Tests for the test to be improved.

Thanks for advice, Filip

I just ran script "run-fast-jsc" because I thought it was enough to cover the corner cases as you explained. now I can find that some tests are missing such as  "fast/js/integer-division-neg2tothe32-by-neg1", etc on jsc-test-list.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.