[Webkit-unassigned] [Bug 94874] [mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 18:57:43 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94874





--- Comment #2 from Huang Dongsung <luxtella at company100.net>  2012-08-23 18:57:41 PST ---
(In reply to comment #1)
> This regressed in http://trac.webkit.org/changeset/122215. The ChangeLog entry for that patch includes the comment: "This patch makes GIF animation outside the viewport be paused."

I'm sorry for this regression.

I think the tiled scrolling disables RenderObject::willRenderImage from checking if the renderer is outside the viewport. "viewRect().intersects(absoluteClippedOverflowRect())" is often used in WebKit, such as spatial navigation.
I think the tiled scrolling should return the proper value.

bool RenderObject::willRenderImage(CachedImage*)
{
    ....
    // If a renderer is outside the viewport, we won't render.
    return viewRect().intersects(absoluteClippedOverflowRect());
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list