[Webkit-unassigned] [Bug 93368] [CSSRegions]Expose WebKitNamedFlowCollection interface through document.getNamedFlows()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93368





--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-23 14:39:12 PST ---
(From update of attachment 159937)
View in context: https://bugs.webkit.org/attachment.cgi?id=159937&action=review

> Source/WebCore/bindings/gobject/GNUmakefile.am:258
> +	DerivedSources/webkit/WebKitDOMWebKitNamedFlowCollection.cpp \

Wrong file name.

> Source/WebCore/bindings/gobject/GNUmakefile.am:392
> +	DerivedSources/webkit/WebKitDOMWebKitNamedFlowCollection.h \

Ditto.

> Source/WebCore/dom/DOMNamedFlowCollection.cpp:52
> +    for (unsigned long i = 0; i < index; ++it, ++i) { }

I'd prefer if you had incremented "it" as a statement in the for so that we don't have to have an awkward { }.

> Source/WebCore/dom/DOMNamedFlowCollection.idl:35
> +    interface [
> +        IndexedGetter,
> +        NamedGetter,
> +        InterfaceName=WebKitNamedFlowCollection,
> +        JSGenerateToJSObject

Shouldn't we have Conditional=CSS_REGIONS

> Source/WebCore/dom/Document.idl:274
>  #if defined(ENABLE_CSS_REGIONS) && ENABLE_CSS_REGIONS
>          WebKitNamedFlow webkitGetFlowByName(in DOMString name);
> +        DOMNamedFlowCollection webkitGetNamedFlows();
>  #endif

Please use [Conditional=CSS_REGIONS]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.