[Webkit-unassigned] [Bug 94779] To reduce cost of converting type during modulo for integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94779





--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2012-08-23 08:38:57 PST ---
(From update of attachment 160089)
View in context: https://bugs.webkit.org/attachment.cgi?id=160089&action=review

> Source/JavaScriptCore/dfg/DFGOperations.h:183
>  double DFG_OPERATION operationFModOnInts(int32_t, int32_t) WTF_INTERNAL;

You should remove this function, since you're replacing it.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2545
> +    speculationCheck(Overflow, JSValueRegs(), NoNode, checkZero);

Did you verify what happens in the recovery path when this speculation fails?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.