[Webkit-unassigned] [Bug 68303] Memory leak using web SQL DB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68303





--- Comment #4 from Dan Carney <dcarney at google.com>  2012-08-23 01:02:51 PST ---
(From update of attachment 159997)
View in context: https://bugs.webkit.org/attachment.cgi?id=159997&action=review

>> Source/WebCore/Modules/webdatabase/Database.cpp:71
>> +    AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex);
> 
> This basically takes a mutex. It is kind of funny if you think about it to take a mutex to create one (and everytime you enter this function as well).
> 
> Instead you could use this macro to initialize currentId and then do an atomic increment.

I copied the code from elsewhere.  I've updated to use atomicIncrement

>> Source/WebCore/Modules/webdatabase/Database.cpp:276
>> +class CloseImmediatelyTask: public ScriptExecutionContext::Task {
> 
> space before :

done.

>> Source/WebCore/Modules/webdatabase/Database.cpp:279
>> +    virtual ~CloseImmediatelyTask() { }
> 
> Why?

leftovers.  removed

>> Source/WebCore/Modules/webdatabase/Database.cpp:297
>> +        m_scriptExecutionContext->postTask(CloseImmediatelyTask::create(this));
> 
> Consider using createCallbackTask instead.

Unfortunately that doesn't work with PassRefPtr<Database>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.