[Webkit-unassigned] [Bug 85484] [EFL] Tracking corner not being painted for TextArea

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 20:18:26 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85484





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-22 20:18:24 PST ---
(From update of attachment 145302)
View in context: https://bugs.webkit.org/attachment.cgi?id=145302&action=review

(In reply to comment #5)

> * I'm not sure the current thickness value is pixel-perfect: someone with more .edc experience could probably tell me...

EFL port hasn't supported pixel test. So, we started to support pixel test in Bug 94188. I think this patch also should support pixel-test as well as layout test. But, too many tests aren't supported by pixel test in EFL port now. So, it may be difficult to find which tests are influenced by this patch. If so, in my opinion, this problem can be handled by a new bug linked to Bug 94188. Any other opinions? 

BTW, are there any differences in layout test ?

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:52
> +    return thickness;

If thickness variable is not used by other functions, it seems return 8; with comment is enough.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp#L817

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list