[Webkit-unassigned] [Bug 62854] Vertical text in ruby element is not rendered properly if writing-mode is set dynamically

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62854


Julien Chaffraix <jchaffraix at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159154|review?                     |review-
               Flag|                            |




--- Comment #5 from Julien Chaffraix <jchaffraix at webkit.org>  2012-08-22 19:10:10 PST ---
(From update of attachment 159154)
View in context: https://bugs.webkit.org/attachment.cgi?id=159154&action=review

Thanks for the patch. r-'ing the patch because it's on the wrong bug, I don't know FreeType so I haven't looked at the change.

> Source/WebCore/ChangeLog:4
> +        [Layout and Rendering] This fix rotates CJK characters -90 degrees when using -webkit-writing-mode as vertical-rl.
> +        This fix is only applied to FreeType font.

It's not good practice to hijack a bug to post your patch. This patch has *nothing* to do with the original bug (which is as you mentioned is specific to ruby) and should be attached on its own bug.

Also you should use the bug title in your ChangeLog, not another name: if the bug title doesn't match what you want, change it to match the underlying bug.

If you are unsure about the bugzilla etiquette, free free to check with people on #webkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.