[Webkit-unassigned] [Bug 94671] Implement UndoManager's item() method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94671





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-22 16:19:34 PST ---
(From update of attachment 160028)
View in context: https://bugs.webkit.org/attachment.cgi?id=160028&action=review

> Source/WebCore/bindings/v8/custom/V8UndoManagerCustom.cpp:82
> +            v8::Handle<v8::Object> object = v8::Object::New();
> +            object->ForceSet(v8::String::NewSymbol("label"), v8::String::NewSymbol("[Editing command]"));

We shouldn't be creating new object each time we return.
e.g. if you do undoManager.item(0)[0].myProperty = 'foo';
then I should be able to get 'foo' on
undoManager.item(0)[0].myProperty
even if item(0)[0] was an object added for an automatic transaction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.