[Webkit-unassigned] [Bug 94699] [GTK] Crash when finalizing WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94699





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2012-08-22 08:15:35 PST ---
(From update of attachment 159921)
View in context: https://bugs.webkit.org/attachment.cgi?id=159921&action=review

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:-244
> -        // Shrink the offscreen window to save memory while accelerated compositing is turned off.
> -        m_redirectedWindow->resize(IntSize(1, 1));
> +        m_redirectedWindow = nullptr;
>          m_rootLayer = nullptr;
>          m_nonCompositedContentLayer = nullptr;
>          m_textureMapper = nullptr;
>          return;
>      }
>  
> -    if (graphicsLayer && !enabled())
> -        m_redirectedWindow->resize(getWebViewSize(m_webView));
> -

Instead of destroying the redirected window here, I think it'd be be safer to resize it. This is important because it's quite common to change the root compositing layer to null and then back. For instance this happens when moving back and forward between pages. This will still avoid creating the redirected window when AC is never used.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.