[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #36 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-08-22 03:58:49 PST ---
(From update of attachment 159894)
View in context: https://bugs.webkit.org/attachment.cgi?id=159894&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1403
> +    WKPageSetCustomUserAgent(toAPI(priv->pageClient->page()), userAgent ? userAgentString.get() : 0);

Won't userAgentString.get() return 0 if userAgent is 0?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1417
> +

if (priv->userAgent.isNull())
    priv->userAgent = WKEinaSharedString(AdoptWK, WKPageCopyUserAgent(toAPI(priv->pageClient->page())));

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:610
> + * @return user agent on success or @c NULL on failure

Please mention that returned string is shared.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.