[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #77 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-22 02:52:48 PST ---
(From update of attachment 159883)
View in context: https://bugs.webkit.org/attachment.cgi?id=159883&action=review

>>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:238
>>>>> +}
>>>> 
>>>> Isn't it more important knowing that it was actually asked to hide, than whether it being the right type. Could you test the former?
>>> 
>>> Well, may I test the picker status here? I mean, whether showcolorPicker() is called or not.
>> 
>> Or, I can check ewk_view_color_picker_color_set() returns false here.
>> 
>> The application should do something here, so I'm not making many test here.
> 
> Why not just add a static bool wasHidden = false; then set it to true and test later

Actually, this function should be called twice because color picker is shown twice. So, I think, global variable is needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.