[Webkit-unassigned] [Bug 93838] [EFL] Use vertical slider theme when the slider is vertical

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93838





--- Comment #10 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-21 23:09:07 PST ---
(In reply to comment #9)
> (In reply to comment #3)
> > And, other ports show same width of vertical slider when I see the expected result. So, the size of slider on EFL should look same as the other ports.
> 
> What I wonder is why the other ports work without having to perform these calls in this method.

(In reply to comment #8)
> (In reply to comment #7) 
> > > Actually, const ThemePartDesc* desc ;)
> > 
> > But, is it really required? All the other parts using 'struct ThemePartDesc'. It breaks code consistency.
> 
> It's not _required_, as the code will not break if you leave it there. But it makes sense to clean up stuff when you are changing it (I personally prefer this approach to those sweeping commits which change a lot of lines at once).

That's a good hint for me. May I file a bug for changing 'struct ThemePartDesc' to 'ThemePartDesc'?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.