[Webkit-unassigned] [Bug 93838] [EFL] Use vertical slider theme when the slider is vertical

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93838


KwangYong Choi <ky0.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159641|review?                     |
               Flag|                            |




--- Comment #3 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-21 22:47:58 PST ---
(From update of attachment 159641)
View in context: https://bugs.webkit.org/attachment.cgi?id=159641&action=review

>> Source/WebCore/ChangeLog:13
>> +        to use the default value of renderer.
> 
> What if you don't resize the slider at all, like the other ports seem to do? Do you get meaningful test results?

The size should be set to default value when the size is not specified. The height of horizontal slider is always 11 and the width of the vertical slider is always 11 without checking the size is greater than 0. It's always 11 even though the size of slider thumb is changed.

Render slider uses defaultTrackLength as 129. And, other ports show same width of vertical slider when I see the expected result. So, the size of slider on EFL should look same as the other ports.

The main problem of existing code is the height of the vertical slider is 11 because it is applied horizontal slider theme and resized by code.

>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:769
>> +    const struct ThemePartDesc* desc;
> 
> I know this construction was already like this, but since you are touch this part you can leave out the `struct' part, it's an unneeded C-ism.

You mean, remove const, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.