[Webkit-unassigned] [Bug 93838] [EFL] Use vertical slider theme when the slider is vertical

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93838





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-08-21 20:01:15 PST ---
(From update of attachment 159641)
View in context: https://bugs.webkit.org/attachment.cgi?id=159641&action=review

> Source/WebCore/ChangeLog:13
> +        And do not resize slider when its size is not specified. It's natural
> +        to use the default value of renderer.

What if you don't resize the slider at all, like the other ports seem to do? Do you get meaningful test results?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:769
> +    const struct ThemePartDesc* desc;

I know this construction was already like this, but since you are touch this part you can leave out the `struct' part, it's an unneeded C-ism.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.