[Webkit-unassigned] [Bug 94560] [EFL] Support slider tick mark snapping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94560





--- Comment #4 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-08-21 18:29:12 PST ---
(From update of attachment 159591)
View in context: https://bugs.webkit.org/attachment.cgi?id=159591&action=review

>>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:817
>>> +    return threshold;
>> 
>> Why not `return 5', perhaps with a comment explaining where the number came from?
> 
> I refer to already merged code above this method.
> 
> int RenderThemeEfl::sliderTickOffsetFromTrackCenter() const
> {
>     static const int sliderTickOffset = -12;
> 
>     return sliderTickOffset;
> }
> 
> What shall I do? change it to 'return 5;' with a comment?

Yes, that looks clearer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.