[Webkit-unassigned] [Bug 93832] text-combine falls back to none rather than scale when wider than 1.1em

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93832





--- Comment #18 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2012-08-21 18:14:29 PST ---
> Ah, I see, thank you. It's probably better to enter a bug, and write the bug #.

I reported bugs and add the IDs to LayoutTest/ChangeLog.
https://bugs.webkit.org/show_bug.cgi?id=94577
https://bugs.webkit.org/show_bug.cgi?id=94654


> Why are these two files removed, not rebaselined?
> Why no mac/fast/writing-mode/combine-compress-expected.png?

I wrote about it at Comment #8.
https://bugs.webkit.org/show_bug.cgi?id=93832#c8

Summary: I think pixel test of Mac is unmaintained or cannot be generated on Mac OS X Lion.


> It looks to me that, in the original code, when m_isCombined is set, font is set to setOrientation(Horizontal) and RenderText::setTextInternal is called, but the patch changes the rule. Setting m_isCombined = true at line 124 looks better to me. Is this intentional and I'm missing something?

You are right.
If the string overflow line and the glyph is not substituted, font description is vertical and the combined text is not replaced by object replacement character.
Your suggestion may be wrong because font description problem is not fixed.

> combine-compress-expected.png is hard to see, especially "compress" line is hardly read. Better to make the font larger.

I enlarge font of test case.
I replaced combine-compress-expected.png by next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.