[Webkit-unassigned] [Bug 95550] Build warning : -Wformat on WebMemorySampler.cpp.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95550


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161658|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2012-08-31 12:04:21 PST ---
(From update of attachment 161658)
View in context: https://bugs.webkit.org/attachment.cgi?id=161658&action=review

A better fix would probably be to use String::number instead of String::format.

>> Source/WebKit2/Shared/WebMemorySampler.cpp:178
>> +            statString.append(String::format("%lu", static_cast<long unsigned int>(memoryStats.values[i])));
> 
> Is it enough *unsigned long* ?

That’s right. In our code we use the name “unsigned long” for this type, not “long unsigned int”, which is equivalent, but not idiomatic. When landing this please use “unsigned long” rather than “long unsigned int”.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.