[Webkit-unassigned] [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 07:23:55 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89666





--- Comment #25 from Szilard Ledan <szledan at inf.u-szeged.hu>  2012-08-31 07:24:01 PST ---
(In reply to comment #23)
> (From update of attachment 157992 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157992&action=review
> 
> This patch is missing a ChangeLog, which I suppose would provide an explanation as to why these changes are submitted? :)

Sorry for the late response!
These patches were only made for testing EWS, and I had the wrong intention that these patches need to be r=? and cq=? to test the EWS.
I'm going to apply your recommendations and hints in the final patch (that will also contain ChangeLogs of course :) ).

> > Source/WebKit2/UIProcess/mac/WebContextMac.mm:-95
> > -    ASSERT(!parameters.nsURLCachePath.isEmpty());
> 
> Technically this ASSERT should move somewhere else, shouldn't it?

>From the final patch nsURLCachePath will be obsoleted.

> > Tools/WebKitTestRunner/TestController.cpp:320
> > +        WKContextSetDatabaseDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> > +        WKContextSetLocalStorageDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> > +        WKContextSetDiskCacheDirectory(m_context.get(), WKStringCreateWithUTF8CString(dumpRenderTreeTemp));
> 
> I think you need to store the strings created by WKStringCreate* in a RetainPtr to avoid them leaking.

I'm going to do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list