[Webkit-unassigned] [Bug 94858] AX: Regression (r126369) - toggle buttons no longer return accessible titles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94858


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161275|review?                     |review-
               Flag|                            |




--- Comment #8 from chris fleizach <cfleizach at apple.com>  2012-08-30 19:17:49 PST ---
(From update of attachment 161275)
View in context: https://bugs.webkit.org/attachment.cgi?id=161275&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:380
> +    bool isButton() const { return roleValue() == ButtonRole || PopUpButtonRole || ToggleButtonRole; }

this logic is wrong. This will make isButton always return true.
i think we want roleValue() == Button || roleValue() == Popup ...
since it will be a bit longer might as well put it in the .cpp file and cache roleValue

AccessibilityRole role = roleValue()
return role == Button || role == Popup ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.