[Webkit-unassigned] [Bug 95517] New: ASSERTion failure when SVG element is removed from document and readded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95517

           Summary: ASSERTion failure when SVG element is removed from
                    document and readded
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: timothy_horton at apple.com
                CC: beidson at apple.com, zimmermann at kde.org,
                    fmalita at chromium.org


See attached test case: if you have an <svg> element in an HTML page, then remove it and add it again, we assert:

ASSERTION FAILED: !m_beginTime
/Volumes/SSD/src/WebKit/OpenSource/Source/WebCore/svg/animation/SMILTimeContainer.cpp(91) : void WebCore::SMILTimeContainer::begin()
1   0x103e43962 WebCore::SMILTimeContainer::begin()
2   0x104082648 WebCore::SVGSVGElement::insertedInto(WebCore::ContainerNode*)
3   0x102b04494 WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument(WebCore::Node*)
4   0x102b00c25 WebCore::ChildNodeInsertionNotifier::notify(WebCore::Node*)
5   0x102afd69a WebCore::updateTreeAfterInsertion(WebCore::ContainerNode*, WebCore::Node*, bool)
6   0x102afd0cd WebCore::ContainerNode::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)
7   0x1039be15a WebCore::Node::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool)

This is because m_beginTime wasn't cleared when the element was removed, so it's still set from this element's previous call to begin().

I have a patch, however, I wonder what behavior is expected? Should animations continue from where they were, or should they restart from the beginning when the <svg> is added to the document?

<rdar://problem/12175583>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.