[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #13 from Anton Obzhirov <a.obzhirov at samsung.com>  2012-08-30 07:40:34 PST ---
(From update of attachment 157749)
View in context: https://bugs.webkit.org/attachment.cgi?id=157749&action=review

>>> Source/WebKit2/UIProcess/InspectorServer/WebSocketServer.cpp:94
>>> +
>> 
>> I don't think we should have something like this here. This kind of logic should go on the platform-specific implementation or be performed by the user agent. We should have public API in the future to start and close down the server, for now I think we should use Qt's approach of initializing the server as part of the WebContext initialization, using the variable, like you did. See: http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/qt/QtWebContext.cpp#L48
> 
> Will undo my change here, hopefully there will be more generic approach in the future.

I found one place which should be good for the server initialization: void WebContext::platformInitializeWebProcess(WebProcessCreationParameters&) in WebContextGtk.cpp.
However with this approach the server will start up regardless if developer extras is enabled or not. (The same for QT port). That doesn't seem to be correct. That's why
in one of my previous patches I started the server in WebPageProxy::initializeWebPage() after checking developer extras. What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.