[Webkit-unassigned] [Bug 95381] [BlackBerry] Modifying how IP domains are handled in Cookies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95381


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161320|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-08-30 07:30:33 PST ---
(From update of attachment 161320)
View in context: https://bugs.webkit.org/attachment.cgi?id=161320&action=review

Looks good, still cleanup to do.

> Source/WebCore/platform/blackberry/CookieManager.h:117
> +    CookieMap* findOrCreateCookieMap(CookieMap* protocolMap, const String& domain, bool isDomainIPAddress, bool findOnly);

This would be better to just use candidateCookie. And I think passing by const & is preferred then to *.

> Source/WebCore/platform/blackberry/ParsedCookie.h:66
> +    void setDomain(const String& domain, bool domainIsIPAddress = false) { m_domain = domain.lower(); m_domainIsIPAddress= domainIsIPAddress; }

Please add a space character before =.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.