[Webkit-unassigned] [Bug 95358] [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95358





--- Comment #7 from David Reveman <reveman at chromium.org>  2012-08-29 21:13:14 PST ---
Ok, I understand now. Thanks for reverting that change, and sorry for breaking this and not paying attention to Nat's comment on bug 94721.

(In reply to comment #5)
> Sorry, I still don't follow.  Could you walk me through the scenario where we complete 2 commits during one vsync period?

This is the sequence I was seeing:

1. beginFrameComplete
2. scheduleUpdateMoreResource
3. enter vsync
 (nothing to draw as still updating resources)
4. leave vsync
5. updateResourcesComplete
6. commit
7. scheduleBeginFrame
8. beginFrameComplete
9. scheduleUpdateMoreResource
10. updateResourcesComplete
12. commit
13. enter vsync
14. draw
15. leave vsync

If I understand this correctly we need to delay "7. scheduleBeginFrame" until after "14. draw", right?

> 
> The mechanism to control this is the scheduler.

I now see how we relied on vsync tick being the only time texture uploads can complete to maintain this behavior.

I'll fix so https://bugs.webkit.org/show_bug.cgi?id=94721 doesn't break this 1-draw-per-commit behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.