[Webkit-unassigned] [Bug 95390] New: expectation overrides can cause REBASELINE modifiers to be dropped

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95390

           Summary: expectation overrides can cause REBASELINE modifiers
                    to be dropped
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: abarth at webkit.org, jchaffraix at webkit.org,
                    ojan at chromium.org, rniwa at webkit.org


If, for example, you mark a test for REBASELINE in platform/chromium/TestExpectations, and there is an overriding line in the skia_test_expectations.txt file, webkit-patch rebaseline-expectations will not see the line with the REBASELINE. 

After r127057, at least we'll log a warning that we didn't find a REBASELINE, but we should either be smarter about this (e.g., log a warning that tests are shadowing others) or stop using rebaseline-expectations altogether ;).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.