[Webkit-unassigned] [Bug 95258] Add support for blendmode to webkit rendering engine

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 14:40:36 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95258





--- Comment #9 from Rik Cabanier <cabanier at adobe.com>  2012-08-29 14:40:39 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (From update of attachment 161292 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=161292&action=review
> > > 
> > > > Source/WebCore/rendering/RenderObject.h:943
> > > > +    bool hasEffectThatNeedsLayer() const { return hasMask() || hasFilter() || hasBlendMode(); } 
> > > 
> > > I think this name is a bit literal. Maybe hasGraphicalEffect() or something? Is there generic name in graphics for these treatments that require that descendants need to be pre-rendered?
> > 
> > That would be a 'group' (aka a layer)
> > Should I rename it to graphicalEffectNeedsGroup()?
> 
> hasGroupEffect()?
> createsGroup()?

createsGroup sounds good. needsGroup would be good too

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list