[Webkit-unassigned] [Bug 95270] New: webkit-patch rebaseline-expectations touches files too many times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95270

           Summary: webkit-patch rebaseline-expectations touches files too
                    many times
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: abarth at webkit.org, jchaffraix at webkit.org,
                    ojan at chromium.org


We are reading and writing each TestExpectations file multiple times regardless of whether there's actually any REBASELINE lines in the file or we actually did anything. 

A partial fix would be to only iterate over the set of unique expectations_dict() values, rather that all of the port names. Another would be to skip rewriting the file if get_rebaselining_failures() returned an empty set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.