[Webkit-unassigned] [Bug 95244] New: ExecutableAllocator should be destructed after Heap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95244

           Summary: ExecutableAllocator should be destructed after Heap
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yoli at rim.com
                CC: fpizlo at apple.com


It is said 

    public:
        Heap heap; // The heap is our first data member to ensure that it's destructed after all the objects that reference it.

But actually Heap can access MetaAllocator

#6  WTF::MetaAllocatorHandle::~MetaAllocatorHandle
#10 ~MacroAssemblerCodeRef
#11 JSC::JITStubRoutine::~JITStubRoutine
#13 JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine
#16 JSC::Heap::~Heap
#17 JSC::JSGlobalData::~JSGlobalData

This is only a problem when ENABLE(ASSEMBLER_WX_EXCLUSIVE) is true, where every ExecutableAllocator has a MetaAllocator instead of sharing the global one.

But I think it is always good to make ExecutableAllocator construct before Heap and destruct after Heap as it never calls Heap, but Heap depends on ExecutableAllocator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.