[Webkit-unassigned] [Bug 94810] Vector::shrinkToFit should use realloc when canCopyWithMemcpy is true

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 11:50:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94810





--- Comment #16 from Benjamin Poulain <benjamin at webkit.org>  2012-08-28 11:50:19 PST ---
> > So you picked the 1K based on measurement on your platform, one of the few that does not use USE_SYSTEM_MALLOC.
> > 
> > And you set the patch for review for all platforms. Don't you see anything wrong with that?
> 
> yes I do :). Probably I shouldn't set it for review. This is why I suggested to use some macros, and I'm asking for help to investigate this plan on other ports...

Having some #ifdef for Blackberry is perfectly reasonable here. It is the only platform for which you can demonstrate your patch is an improvement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list