[Webkit-unassigned] [Bug 95187] Web Inspector: Add ability to replay XHR in network panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95187





--- Comment #5 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-28 06:39:05 PST ---
(From update of attachment 160961)
View in context: https://bugs.webkit.org/attachment.cgi?id=160961&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:165
> +    static void didCreateXHRRequestImpl(InstrumentingAgents*, String, bool, PassRefPtr<FormData>, const HTTPHeaderMap&, bool, String, String);

...Impl methods should be below (together with the others).

> Source/WebCore/inspector/InspectorInstrumentation.h:167
> +    static void preflightRequestSuccededImpl(InstrumentingAgents*, unsigned long);

Ditto

> Source/WebCore/inspector/InspectorResourceAgent.cpp:226
> +        m_preflightIdToRequestId.add(requestId, IdentifiersFactory::requestId(m_preflightRequestId));

m_resourcesData->setXHRReplayData(requestId, m_resourcesData->XHRData(m_preflightRequestId));
This way you don't need this map at all.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:650
> +    , m_XHRData(0)

m_XHRReplayData

> Source/WebCore/inspector/InspectorResourceAgent.h:164
> +    unsigned long m_preflightRequestId;

I eould call it m_xhrReplayDataRequestId and reuse in replayXHR to avoid duplicating xhrReplayData for replayed xhrs.

> Source/WebCore/inspector/InspectorResourceAgent.h:165
> +    HashMap<String, String> m_preflightIdToRequestId;

This map is not really needed, see above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.