[Webkit-unassigned] [Bug 95177] New: check-webkit-style fails when WebKit is in a Git submodule

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95177

           Summary: check-webkit-style fails when WebKit is in a Git
                    submodule
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kevin.funk at kdab.com


The problem is in /Tools/Scripts/webkitpy/common/checkout/scm/git.py, function find_checkout_root().

If WebKit is checked out using git submodules, git.py identifies "$WEBKIT_SUBMODULE\..\.git\modules" as the checkout root, which is wrong.

===
Example (here: Qt5 repository layout):
qt5
- qtbase (submodule)
- ...
- qtwebkit (submodule)

Issue: find_checkout_root() then returns "qt5/.git/modules" as the checkout root (wrong!).
===

Patch following.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.