[Webkit-unassigned] [Bug 92961] [EFL] Add support for localization to the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92961





--- Comment #3 from Seokju Kwon <seokju.kwon at samsung.com>  2012-08-27 21:49:22 PST ---
(In reply to comment #2)
> (From update of attachment 156025 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156025&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:96
> > +    String inspectorUri = inspectorFilesPath() + String("/inspector.html");
> 
> It is enough to use "/inspector.html"
> 
> > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:143
> > +    String inspectorFilesPath = String("file://") + WEB_INSPECTOR_INSTALL_DIR;
> 
> ditto.
> 
> > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:145
> > +        inspectorFilesPath = String("file://") + WEB_INSPECTOR_DIR;
> 
> ditto.
> 
> > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:171
> > +    return m_inspectorClient->inspectorFilesPath() + String("/localizedStrings.js");
> 
> ditto.

Ok. I will remove String().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.