[Webkit-unassigned] [Bug 93646] Refactor V8 bindings to allow content scripts to access subframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93646





--- Comment #7 from Adam Barth <abarth at webkit.org>  2012-08-27 11:45:27 PST ---
(From update of attachment 160690)
View in context: https://bugs.webkit.org/attachment.cgi?id=160690&action=review

Looks like you have some test failures.  This patch looks very promising.  I need to study it in more detail.

Is it possible to make this change in smaller steps?  There's a lot to digest in this patch.

> Source/WebCore/bindings/v8/DOMWrapperWorld.cpp:69
> +    v8::Persistent<v8::Context> localCopy = v8::Persistent<v8::Context>::New(context);

Can we store this Persistent handle as a ScopedPersistent on DOMWrapperWorld?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.