[Webkit-unassigned] [Bug 95097] New: [NRWT] XvfbDriver should stop the Xvfb more aggressively

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95097

           Summary: [NRWT] XvfbDriver should stop the Xvfb more
                    aggressively
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zandobersek at gmail.com
                CC: ossy at webkit.org, pnormand at igalia.com,
                    kkristof at inf.u-szeged.hu


When XvfbDriver is stopping, it tries to shut down its Xvfb instance in a 'polite' way, by calling terminate(). This doesn't always succeed, with the layout-tests step in the builders timing out:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/28021
(Admittedly blaming the Xvfb is just a very good guess, I can't confirm this myself though.)

The hisorical GtkDriver (on which the XvfbDriver is based) used to be more aggressive, killing Xvfb unconditionally[1]. I recommend following this behavior, but using the Executive class to kill the process.

For good measure and (again based on guessing) to get rid of the continuous trouble of tests timing out on the GTK 64-bit Debug builder[2], I
also recommend killing any stale Xvfb instances through the kill-old-processes script[3]

[1] http://trac.webkit.org/changeset/116212
[2] http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug
[3] http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/kill-old-processes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.