[Webkit-unassigned] [Bug 95073] WindowShell and global registers break IC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95073





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2012-08-27 07:58:00 PST ---
(From update of attachment 160696)
View in context: https://bugs.webkit.org/attachment.cgi?id=160696&action=review

> Source/WebCore/bindings/js/JSDOMWindowShell.cpp:99
> -    return thisObject->window()->methodTable()->getOwnPropertySlot(thisObject->window(), exec, propertyName, slot);
> +    const bool res = thisObject->window()->methodTable()->getOwnPropertySlot(thisObject->window(), exec, propertyName, slot);
> +    slot.forceUncacheable();
> +    return res;

Why do you need to forceUncacheable() in addition to the other change?

This looks like it could have severe performance consequences.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.